[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py:21
+    @add_test_categories(["libc++"])
+    @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '5.0'])
+
----------------
labath wrote:
> Could you add another line for `gcc` here? The -std=c++17 flag seems to be supported starting with gcc-5.1.
> 
> Also a comment that this is due to the -std flag would be helpful to people looking at this in the future.
Adding a comment makes sense.

So `@add_test_categories(["libc++"])` won't skip for gcc bots then?


https://reviews.llvm.org/D49271