[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Thank you for updating the patch.

If I understand things correctly, we could avoid circular deps and untyped pointers (or `llvm::Any`, which is essentially the same thing), by moving `CPlusPlusLanguage::MethodName` to a separate file. Could we do that as a preparatory step for this patch?



================
Comment at: source/Symbol/Symtab.cpp:220
+namespace {
+bool lldb_skip_name(llvm::StringRef mangled, Mangled::ManglingScheme scheme) {
+  switch (scheme) {
----------------
make this `static` and drop the surrounding namespace.


https://reviews.llvm.org/D50071