[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py:21
+    @add_test_categories(["libc++"])
+    @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '5.0'])
+
----------------
Could you add another line for `gcc` here? The -std=c++17 flag seems to be supported starting with gcc-5.1.

Also a comment that this is due to the -std flag would be helpful to people looking at this in the future.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/TestDataFormatterLibcxxOptional.py:44
+        if output == "(bool) has_optional = false" :
+            exit(0)
+
----------------
Replace by `self.skipTest(...)`. This way, the test will be properly marked as skipped.


================
Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/optional/main.cpp:15-17
+using optional_int = std::optional<int> ;
+using optional_int_vect = std::optional<int_vect> ;
+using optional_string = std::optional<std::string> ;
----------------
these need to be guarded by the `#if` too (i'd just move then into the main function).


https://reviews.llvm.org/D49271