[Lldb-commits] [PATCH] D50038: Introduce install-lldb-framework target

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 30 19:42:43 PDT 2018

xiaobai created this revision.
xiaobai added reviewers: labath, sas.
Herald added a subscriber: mgorny.

Previously, I thought that install-liblldb would fail because CMake had
a bug related to installing frameworks. In actuality, I misunderstood the
semantics of `add_custom_target`: the DEPENDS option refers to specific files,
not targets. Therefore `install-liblldb` should rely on the actual liblldb
getting generated rather than the target.

This means that the previous patch I committed (to stop relying on CMake's
framework support) is no longer needed and has been reverted. Using CMake's
framework support greatly simplifies the implementation.

`install-lldb-framework` (and the stripped variant) is as simple as
depending on `install-liblldb` because CMake knows that liblldb was built as a
framework and will install the whole framework for you. The stripped variant
will depend on the stripped variants of individual tools only to ensure they
actually are stripped as well.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50038.158166.patch
Type: text/x-patch
Size: 4453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180731/7e90d5e6/attachment.bin>

More information about the lldb-commits mailing list