[Lldb-commits] [PATCH] D49990: Use rich mangling information in Symtab::InitNameIndexes()

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: include/lldb/Symbol/Symtab.h:58
+  /// dependency. Keep a void* here instead and cast it on-demand on the cpp.
+  void *m_legacy_parser = nullptr;
+
----------------
sgraenitz wrote:
> sgraenitz wrote:
> > zturner wrote:
> > > sgraenitz wrote:
> > > > This is the hackiest point I guess.
> > > We have `llvm::Any`.  Perhaps you want to use that here instead of `void*`?
> > Thanks. I will check that.
> @zturner Where is `llvm::Any`? Expected it in ADT or Support, but can't find it. IIUC `llvm::Optional` does something similar, but uses its own `optional_detail::OptionalStorage`. Same for `llvm::Expected`. Or is it a very recent addition?
It's pretty recent.  I was actually the one who added it, about maybe 2 weeks ago.  It's in `include/llvm/ADT/Any.h`


https://reviews.llvm.org/D49990