[Lldb-commits] [PATCH] D49990: Use rich mangling information in Symtab::InitNameIndexes()

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: include/lldb/Core/Mangled.h:25-34
+namespace lldb_private {
+class RichManglingInfo;
+class RichManglingSpec;
+}
 namespace lldb_private {
 class RegularExpression;
 }
----------------
move any forward decls to lldb-forward.h and remove all manual forward declarations in lldb_private from here.


================
Comment at: include/lldb/Symbol/Symtab.h:26
+/// providers. See Mangled::DemangleWithRichManglingInfo()
+class RichManglingInfo {
+public:
----------------
move to separate files RichManglingInfo.h and RichManglingInfo.cpp


================
Comment at: include/lldb/Symbol/Symtab.h:93
+/// Unique owner of RichManglingInfo. Handles initialization and lifetime.
+class RichManglingSpec {
+public:
----------------
move to separate files RichManglingInfo.h and RichManglingInfo.cpp


https://reviews.llvm.org/D49990