[Lldb-commits] [PATCH] D49969: DWZ 04/06: ManualDWARFIndex::GetGlobalVariables for DIEs in PUs

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil created this revision.
jankratochvil added reviewers: labath, clayborg.
Herald added a subscriber: JDevlieghere.

Rarely (`GlobalVariablesTestCase-test_c_global_variables`) a DIE can be only in PU (PartialUnit), that is if a DIE is a static constant variable (`g_file_static_int`) so that it has no location address.

Patch has been optimized for minimal code added despite the performance is suboptimal for DWZ files. It also should not affect non-DWZ files performance.

All DWZ patches are also applied in: git clone -b dwz git://git.jankratochvil.net/lldb


https://reviews.llvm.org/D49969

Files:
  source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
  source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h
  source/Plugins/SymbolFile/DWARF/NameToDIE.cpp
  source/Plugins/SymbolFile/DWARF/NameToDIE.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49969.157901.patch
Type: text/x-patch
Size: 7375 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180729/690725ef/attachment.bin>