[Lldb-commits] [PATCH] D49909: Unit test for Symtab::InitNameIndexes

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I am wondering whether a test like this wouldn't be better of as a lit test instead of a unit test.

Right now, if you do a `lldb-test symbols foo.o` (and foo.o contains debug info), we will dump out a very similar index which is built from the information in the debug_info sections:

  Manual DWARF index for (x86_64) 'foo.o':
  Function basenames:
  0x62a4e88: {0x00000000/0x0000005c} "__cxx_global_var_init"
  
  Function fullnames:
  0x6188e10: {0x00000000/0x0000012a} "_ZN1AC2Ez"
  0x62a4e88: {0x00000000/0x0000005c} "__cxx_global_var_init"
  ...

I think it makes sense to extend this dump to include the index information from the Symtab class too. Then it should be possible to write this test the traditional LLVM way as `yaml2obj | lldb-test | FileCheck`.

What do you think?


https://reviews.llvm.org/D49909