[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

[Keith Smiley via Phabricator via lldb-commits]

keith added inline comments.


================
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+  DEPENDS ${framework_headers}
+  COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
----------------
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
> > > keith wrote:
> > > > xiaobai wrote:
> > > > > This should not just depend on `framework_headers`, because those are in the location `${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders`. You want to run the script on `$<TARGET_FILE_DIR:liblldb>/Headers`, which is not guaranteed to exist or have been populated with headers when this actually gets run. See my comment above.
> > > > Updated this by making it a POST_BUILD command instead
> > > Can you combine this with the lldb-framework POST_BUILD above? After that this should be good to go.
> > If I combine it with the one above I'd have to do it twice I think?
> I think if you insert the command after moving the headers then you shouldn't have to do it twice
I might be misunderstanding the suggestion. I think I would have to after line 21 and line 28


https://reviews.llvm.org/D49779