[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

[Eugene Birukov via Phabricator via lldb-commits]

EugeneBi added a comment.

In https://reviews.llvm.org/D49685#1176399, @labath wrote:

> In https://reviews.llvm.org/D49685#1175413, @EugeneBi wrote:
>
> > In https://reviews.llvm.org/D49685#1174770, @labath wrote:
> >
> > > Could you also add a test for this?
> >
> >
> > I never ran LLDB tests, not sure where they are and what they are.
> >  Also, how would you test that? I know now my open core dump works, but I cannot share it.
>
>
> Good question. Is this functionality specific to shared libraries, or could it be used to locate the main exe too?
>
> If yes, then it should be sufficient to take one of the existing core&exe files we have, copy the exe into a path matching what the core file expects, set the sysroot, and make sure the exe gets found when we open up the core file. You can look at the existing tests in `test/testcases/functionalities/postmortem/elf-core` for examples.
>
> If not, then it might get trickier because we'll need new core files, and it's hard to generate small ones with shared libraries.


It is specific to shared libraries. Opening the executable and core dump follows different code path.


https://reviews.llvm.org/D49685