[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 25 13:27:04 PDT 2018

teemperor added inline comments.

Comment at: source/Core/Highlighter.cpp:34
+  // Calculate how many bytes we have written.
+  return m_prefix.size() + value.size() + m_suffix.size();
labath wrote:
> This isn't correct, as you're not writing m_prefix, but it's transmogrified version. Btw, do you really need this return value anyway?
Good catch. And the return value is just to make the SourceManager happy which always returns the total amount of bytes written. I'm working on a patch that will move all the 'written byte counting' in lldb into the Stream class, but as of now that's how it works.


More information about the lldb-commits mailing list