[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 25 12:35:07 PDT 2018

apolyakov added inline comments.

Comment at: lit/lit.cfg:59
-debugserver = lit.util.which('debugserver', lldb_tools_dir)
+if platform.system() in ['Darwin']:
+    debugserver = lit.util.which('debugserver', lldb_tools_dir)
Do we have `debugserver` only on macOS? On other OS it's called `lldb-server`?

Comment at: source/API/SBTarget.cpp:1468
+  }
+  if (from[0] && to[0]) {
+    Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
I didn't find nullptr check in other API functions, is it OK or it's better to add it?


More information about the lldb-commits mailing list