[Lldb-commits] [lldb] r337932 - [ProcessGDBRemote] handle result from ConnectToDebugserver

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 25 08:20:15 PDT 2018


Author: jdevlieghere
Date: Wed Jul 25 08:20:15 2018
New Revision: 337932

URL: http://llvm.org/viewvc/llvm-project?rev=337932&view=rev
Log:
[ProcessGDBRemote] handle result from ConnectToDebugserver

We ignored the result from ConnectToDebugserver, causing certain errors
(like a failed handshake) not to surface.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=337932&r1=337931&r2=337932&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Wed Jul 25 08:20:15 2018
@@ -3484,7 +3484,7 @@ Status ProcessGDBRemote::LaunchAndConnec
     if (m_gdb_comm.IsConnected()) {
       // Finish the connection process by doing the handshake without
       // connecting (send NULL URL)
-      ConnectToDebugserver("");
+      error = ConnectToDebugserver("");
     } else {
       error.SetErrorString("connection failed");
     }




More information about the lldb-commits mailing list