[Lldb-commits] [PATCH] D49685: LLDB does not respect platform sysroot when loading core on Linux

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 24 02:57:40 PDT 2018

labath added a comment.

Which version is this patch based on? The line numbers don't seem to match what I see on master.

Could you rebase the patch to master, and upload the patch with a full diff (e.g. via `git diff -U9999`, see https://llvm.org/docs/Phabricator.html#id3).

Comment at: include/lldb/Core/ModuleList.h:545
+                                bool always_create = false,
+                                const char* sysroot = nullptr);
   static bool RemoveSharedModule(lldb::ModuleSP &module_sp);
Please make this an `llvm::StringRef` (and then change `AsCString` to `GetStringRef` below).



More information about the lldb-commits mailing list