[Lldb-commits] [PATCH] D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 23 09:52:33 PDT 2018


apolyakov added a comment.

In https://reviews.llvm.org/D47302#1171639, @clayborg wrote:

> We could end up moving anything that is set by a target property into the lldb_private target property class if it isn't already there and then that would fix things.


If you remember, we started this discussion from adding the `AppendImageSearchPath(const char *from, const char *to)` method. To do so, we need to modify `Target`'s member variable 
`m_image_search_paths`. It means that to move this option to TargetProperties we have to also move this member variable from `Target` to `TargetProperties`. We need to be sure that it won't break anything.


https://reviews.llvm.org/D47302





More information about the lldb-commits mailing list