[Lldb-commits] [PATCH] D48351: Move dumping code out of RegisterValue class

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 23 04:07:00 PDT 2018

labath added a comment.

In https://reviews.llvm.org/D48351#1169959, @jingham wrote:

> Dump is really meant to be the private description of the object that you would use for logging and the like - Description was the public face of a class.  So while the Description-like functionality could have a restrictions that constrain its use to pretty high up in the stack, you really want to be able to Dump some object you've been handed - particularly into the log stream - wherever that might help.  So I don't think moving to restrict where you can use Dump is a good idea.

I fully agree with that. It should be easy to add a simple dump function for logging purposes which omits any fancy formatting that need higher level constructs to any object. It's just that the current dump function is used for both things: logging, and displaying information to the user.  I can change the name to DescribeRegisterValue or something like that if you think that makes more sense.


More information about the lldb-commits mailing list