[Lldb-commits] [PATCH] D48351: Move dumping code out of RegisterValue class

[Pavel Labath via lldb-commits]

This is the current list of files (after this patch) that call
DumpDataExtractor or DumpRegisterValue

source/API/SBData.cpp
source/Commands/CommandObjectMemory.cpp
source/Commands/CommandObjectRegister.cpp
source/Core/Address.cpp
source/Core/EmulateInstruction.cpp
source/Core/Event.cpp
source/Core/FormatEntity.cpp
source/DataFormatters/TypeFormat.cpp
source/Expression/Materializer.cpp
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
source/Symbol/ClangASTContext.cpp
source/Symbol/GoASTContext.cpp
source/Symbol/JavaASTContext.cpp
source/Symbol/OCamlASTContext.cpp
source/Target/ThreadPlanCallFunction.cpp
source/Target/ThreadPlanTracer.cpp

as you can see, pretty much each of the non-plugin modules is represented.

On Fri, 20 Jul 2018 at 16:04, Zachary Turner <zturner at google.com> wrote:
>
> We only use dumping from lldb-test, from inside the debugger, or from the top level command interpreter. All of those things necessarily depend on everything anyway.

I'm not saying I wouldn't like a world where this statement is true,
but I think we're still very far from there.

Maybe the best thing would be to just keep this in separate files in
Core until we reach a point we can do something about them.