[Lldb-commits] [PATCH] D48351: Move dumping code out of RegisterValue class

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 19 10:22:08 PDT 2018

labath added a comment.

The Stream part isn't the problem. The problem is that the dumping code is implemented in terms of `ExecutionContextScope`, which then pulls in pretty much everything. If it was just the object "dumping itself" then I would be fine with it as a method, but here it's using the whole world to achieve that goal. At that point I would prefer it living in a separate place (though we can debate on whether it should be a completely separate file, or merged to a single file with the DumpDataExtractor code)


More information about the lldb-commits mailing list