[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 19 07:36:56 PDT 2018


aleksandr.urakov added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:273
+        udt->getClassParent()) {
+      access = GetDefaultAccessibilityForUdtKind(udt_kind);
+    }
----------------
Yes, we can occur here, as I have mentioned at the line 186. But if I understand correctly for following code:

```
class C {
  struct S {
  };
};
```
we will retrieve `public` as the access for `S`, but must retrieve `private`, right? May be we need to get the default accessibility of the class parent?


https://reviews.llvm.org/D49410





More information about the lldb-commits mailing list