[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:186
+    return lldb::eAccessProtected;
+  return lldb::eAccessNone;
+}
----------------
zturner wrote:
> I wonder if this would be better as an `llvm_unreachable`.  Being able to assume this function returns a sane value would simplify calling code.
PDBSymbolTypeUDT::getType() returns PDB_MemberAccess that equals 0, so we can't make it `llvm_unreachable`.


https://reviews.llvm.org/D49410