[Lldb-commits] [PATCH] D49415: Add unit tests for VMRange

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 18 01:14:20 PDT 2018


labath added a comment.

In https://reviews.llvm.org/D49415#1165179, @teemperor wrote:

> - Added a PrintTo function as otherwise the gtest comparison macros won't compile.


Sorry, I did not anticipate that. It looks like the `iterator` typedef inside the VMRange is confusing gtest's universal printing logic (normally it does not require a type to be printable and it will just print a hex dump instead). In any case, having the PrintTo function is a good thing, so thanks for adding it.


https://reviews.llvm.org/D49415





More information about the lldb-commits mailing list