[Lldb-commits] [PATCH] D49411: Move from StringRef to std::string in the ScriptInterpreter API

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 17 10:18:19 PDT 2018


clayborg added a comment.

Much simpler solution is inlined. Let me know what you think?



================
Comment at: source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:859
                 PyRefType::Owned,
-                Py_BuildValue("(Os)", session_dict.get(), command_str.c_str()));
+                Py_BuildValue("(Os)", session_dict.get(), command.c_str()));
             if (pargs.IsValid()) {
----------------
Remove everything in this patch and just do:

```
Py_BuildValue("(Os#)", session_dict.get(), command.data(), (int)command.size()));
```


https://reviews.llvm.org/D49411





More information about the lldb-commits mailing list