[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 17 03:40:36 PDT 2018
labath added a comment.
I suppose we can add an off-by-default DWP mode so that it can be used for integration testing.
However, I wouldn't consider any future DWP changes "tested" if the code is only exercised via this mode. As I said above, I think the majority of DWP code can be exercised without even running a process via `lldb-test`. If there are any odd corner casees that can be only reached by running the full pipeline, then we add a couple of specialized tests which explicitly set MAKE_DWP=YES, and are run unconditionally (similar to how we have two debug_names tests run via dotest because the functionality was not accessible via lldb-test).
After some thought, I don't think the script idea I came up with initially is necessary here, though the situation may be different for DWZ, as the dwz utility seems to be quite temperamental -- IIRC it will error out if the input file happens to not contain a .debug_info section. For the purposes of integration testing I think it would be better to just silently accept these so that all tests work "out of the box" with dwz. It might be nice to hide these details in a wrapper script.
More information about the lldb-commits