[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I have no opinion on the implementation, but I like that you wrote a non-execution test for this, as this will enable us one day to run it on non-windows hosts too.



================
Comment at: lit/SymbolFile/PDB/class-layout.test:50-53
+CHECK-DAG:    _List *array[90];
+CHECK-DAG:    int x;
+CHECK-DAG:    int a;
+CHECK-DAG:    float b;
----------------
Should these actually be check-**DAG**s? I am assuming the member order will impact the final class layout, so you need to match the source code order here. (I don't know how hard would it be, but it might be interesting to change the dumping code to produce final element offsets, so you can assert the exact structure layout).


Repository:
  rL LLVM

https://reviews.llvm.org/D49410