[Lldb-commits] [PATCH] D49406: Invert dependency between lldb-framework and lldb-suite
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jul 16 16:01:04 PDT 2018
xiaobai created this revision.
xiaobai added reviewers: sas, labath.
Herald added a subscriber: mgorny.
Currently, if you build lldb-framework the entire framework doesn't
actually build. In order to build the entire framework, you need to actually
build lldb-suite. This abstraction doesn't feel quite right because
lldb-framework truly does depend on lldb-suite (liblldb + related tools).
In this change I want to invert their dependency. This will mean that lldb and
finish_swig will depend on lldb-framework in a framework build, and lldb-suite
otherwise. Instead of adding conditional logic everywhere to handle this, I
introduce LLDB_SUITE_TARGET to handle it.
I tested this by building lldb with:
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLDB_CODESIGN_IDENTITY=""
-DLLDB_BUILD_FRAMEWORK=1 -DLLDB_USE_SYSTEM_SIX=1 -DCMAKE_INSTALL_PREFIX=""
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3618 bytes
Desc: not available
More information about the lldb-commits