[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The CHECK-SAME expression on line 10 can no longer find the expected string in the output. This is due to an extra `location = DW_OP_addr(0000000140004114) ,` in the output between the two expected strings `CHECK-SAME: scope = global, external`, so it looks like it is this change that is causing the failure. This can be fixed by updating the CHECK-SAME expression, but I will leave it up to you to decide if that is the correct fix. I also noticed that `location = DW_OP_addr(0000000140004114) ,` has an extra space before the comma which other values do not. Here is the log:

`location = DW_OP_addr(0000000140004114) ,`

           # command stderr:
  ##[error]llvm\tools\lldb\lit\SymbolFile\PDB\variables.test(10,13): Error GBE9F3850: CHECK-SAME: expected string not found in input
       3>C:\agent1\_work\15\s\llvm\tools\lldb\lit\SymbolFile\PDB\variables.test(10,13): error GBE9F3850: CHECK-SAME: expected string not found in input [C:\agent1\_work\15\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]
           
           CHECK-SAME: scope = global, external
           
                       ^
           
           <stdin>:117:58: note: scanning from here
           
           0000022CA2072050: Variable{0x00000002}, name = "g_IntVar", type = {0000000000000004} 0x0000022ca20c2390 (int), scope = global, location = DW_OP_addr(0000000140004114) , external
           
                                                                    ^
           
           <stdin>:117:112: note: possible intended match here
           
           0000022CA2072050: Variable{0x00000002}, name = "g_IntVar", type = {0000000000000004} 0x0000022ca20c2390 (int), scope = global, location = DW_OP_addr(0000000140004114) , external




Repository:
  rL LLVM

https://reviews.llvm.org/D49018