[Lldb-commits] [lldb] r337173 - Fix TestDataFormatterUnordered for older libc++ versions

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 16 07:37:58 PDT 2018


Author: labath
Date: Mon Jul 16 07:37:58 2018
New Revision: 337173

URL: http://llvm.org/viewvc/llvm-project?rev=337173&view=rev
Log:
Fix TestDataFormatterUnordered for older libc++ versions

clang recently started diagnosing "exception specification in
declaration does not match previous declaration" errors. Unfortunately
old libc++ versions had a bug, where they violated this rule, which
means that tests using this library version now fail due to build
errors.

Since it was easy to work around the bug by compiling this test with
-fno-exceptions, I do that here. If supporting old libc++ versions
becomes a burden, we'll have to revisit this.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile?rev=337173&r1=337172&r2=337173&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/Makefile Mon Jul 16 07:37:58 2018
@@ -2,6 +2,11 @@ LEVEL = ../../../../../make
 
 CXX_SOURCES := main.cpp
 
+# Work around "exception specification in declaration does not match previous
+# declaration" errors present in older libc++ releases. This error was fixed in
+# the 3.8 release.
+CFLAGS_EXTRAS += -fno-exceptions
+
 USE_LIBCPP := 1
 include $(LEVEL)/Makefile.rules
 CXXFLAGS += -O0




More information about the lldb-commits mailing list