[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Davide Italiano via Phabricator via lldb-commits]

davide added a comment.

This is getting really close. Please try the `lldbInline` test format and revert the unrelated bits and I'll take another look.
 Thanks!



================
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:971-972
     g_formatters.push_back([](lldb_private::ValueObject &valobj,
-                              lldb::DynamicValueType,
-                              FormatManager &
-                                  fmt_mgr) -> SyntheticChildren::SharedPointer {
+                              lldb::DynamicValueType, FormatManager &fmt_mgr)
+                               -> SyntheticChildren::SharedPointer {
       static CXXSyntheticChildren::SharedPointer formatter_sp(
----------------
this looks unrelated?


================
Comment at: source/Plugins/Language/CPlusPlus/LibCxx.cpp:179-223
+      CompilerType pair_type(
+          __i_->GetCompilerType().GetTypeTemplateArgument(0));
+      std::string name;
+      uint64_t bit_offset_ptr;
+      uint32_t bitfield_bit_size_ptr;
+      bool is_bitfield_ptr;
+      pair_type = pair_type.GetFieldAtIndex(
----------------
this looks like .. unrelated?


https://reviews.llvm.org/D49271