[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Aaron Smith via lldb-commits]

Sure, I will do it Monday if someone hasn’t done it already. 

> On Jul 12, 2018, at 9:22 PM, Aleksandr Urakov via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> aleksandr.urakov updated this revision to Diff 155154.
> aleksandr.urakov added a comment.
> 
> Thanks a lot, I have updated the patch!
> 
> I also have added a test case for a non-zeroth frame (it became possible after https://reviews.llvm.org/D49111).
> 
> If it's all right, can you commit this for me, please? I have no commit access.
> 
> 
> https://reviews.llvm.org/D49018
> 
> Files:
>  lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp
>  lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
>  lit/SymbolFile/PDB/variables-locations.test
>  source/Plugins/SymbolFile/PDB/CMakeLists.txt
>  source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.cpp
>  source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h
>  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
> 
> <D49018.155154.patch>