[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Aaron Smith via Phabricator via lldb-commits]

asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.

Except for minor formatting LGTM



================
Comment at: lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp:7
+
+  return;
+}
----------------
Please remove the return


================
Comment at: source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h:26
+//------------------------------------------------------------------------------
+/// Converts a location information from a PDB symbol to a DWARF expression
+///
----------------
Are you sure about the /// ?

Should these be // ?


https://reviews.llvm.org/D49018