[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:22
     @skipIfDarwin   # pexpect is known to be unreliable on Darwin
     @skipIfFreeBSD  # llvm.org/pr22411: Failure presumably due to known thread races
     def test_lldbmi_data_disassemble(self):
----------------
apolyakov wrote:
> aprantl wrote:
> > It would be *awesome* if we could also convert this entire to a lit/FileCheck. Looks like all the tests in this file are basically skipped everywhere because it's so unreliable...
> It's problematic to convert `data-info-line` test to a lit one since we don't know addresses of a source lines. It means that we can't do this:
> `-data-info-line *0xsome_address`
I see. You are right, we can't change make one command input depend on previous output in a LIT-based test. But it looks like this is only needed for testing one form of the data-info-line command. We could extract everything else into a LIT-based test that runs on every platform and still   greatly improve the test coverage.


https://reviews.llvm.org/D49062