[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 9 10:04:37 PDT 2018


apolyakov added inline comments.


================
Comment at: tools/lldb-mi/MICmdCmdData.cpp:1691
+        break;
+      for (uint32_t j = 0, e = cu.GetNumLineEntries(); j < e; ++j) {
+        const lldb::SBLineEntry &curLine = cu.GetLineEntryAtIndex(j);
----------------
aprantl wrote:
> @clayborg: Is there something better we could do instead of doing a linear search through all debug line entries?
I think we can get rid of this by adding a new method to SBModule - `ResolveSymbolContextsForFileSpec`, which will use a method with the same from Module.


https://reviews.llvm.org/D49062





More information about the lldb-commits mailing list