[Lldb-commits] [lldb] r335934 - Fix path completion test case added in rL335905 on Windows
Raphael Isemann via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 28 15:40:10 PDT 2018
Author: teemperor
Date: Thu Jun 28 15:40:10 2018
New Revision: 335934
URL: http://llvm.org/viewvc/llvm-project?rev=335934&view=rev
Log:
Fix path completion test case added in rL335905 on Windows
Summary:
The test fails because we don't rewrite the slash behind `foo` to the OS specific
separator (as the completion API doesn't support this kind of rewriting). However,
we assume that this part of the string is rewritten in the test case, which broke
on Windows.
Reviewers: stella.stamenova
Reviewed By: stella.stamenova
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D48746
Modified:
lldb/trunk/unittests/Interpreter/TestCompletion.cpp
Modified: lldb/trunk/unittests/Interpreter/TestCompletion.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Interpreter/TestCompletion.cpp?rev=335934&r1=335933&r2=335934&view=diff
==============================================================================
--- lldb/trunk/unittests/Interpreter/TestCompletion.cpp (original)
+++ lldb/trunk/unittests/Interpreter/TestCompletion.cpp Thu Jun 28 15:40:10 2018
@@ -286,14 +286,12 @@ TEST_F(CompletionTest, DirCompletionUser
Count = CommandCompletions::DiskDirectories("~/foo/", Results, Resolver);
ASSERT_EQ(1u, Count);
ASSERT_EQ(Count, Results.GetSize());
- EXPECT_TRUE(ContainsExactString(Twine("~/foo") + path::get_separator() +
- "nested" + path::get_separator(),
+ EXPECT_TRUE(ContainsExactString(Twine("~/foo/nested") + path::get_separator(),
Results));
Count = CommandCompletions::DiskDirectories("~/foo/nes", Results, Resolver);
ASSERT_EQ(1u, Count);
ASSERT_EQ(Count, Results.GetSize());
- EXPECT_TRUE(ContainsExactString(Twine("~/foo") + path::get_separator() +
- "nested" + path::get_separator(),
+ EXPECT_TRUE(ContainsExactString(Twine("~/foo/nested") + path::get_separator(),
Results));
// With ~username syntax it should return one match if there is an exact
More information about the lldb-commits
mailing list