[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 28 18:17:29 PDT 2018

jingham added a comment.

This behavior change seems desirable.  But there are other commands that use the IOHandlerActivated method to print instructions like this, and should get the same treatment (breakpoint command add, type summary add...).  It seems ugly to have to do this one by one in individual commands.

The IOHandlerDelegate is a pretty general class, so I don't think it is right for the IOHandler to only dispatch "IOHandlerActivated" to it when interactive.  There's no requirement that the work you do in this method is only useful when interactive.  But it might work if the IOHandlerDelegate could say whether it wants to be notified for IOHandlerActivated when non-interactive (like have a "ShouldNotifyWhenNonInteractive" method), and then the IOHandler could dispatch it or not based on the response to that method.


More information about the lldb-commits mailing list