[Lldb-commits] [lldb] r335906 - [lldbsuite] Fix TestBreakpointHitCount on Windows

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 28 12:42:30 PDT 2018


Author: stella.stamenova
Date: Thu Jun 28 12:42:30 2018
New Revision: 335906

URL: http://llvm.org/viewvc/llvm-project?rev=335906&view=rev
Log:
[lldbsuite] Fix TestBreakpointHitCount on Windows

Summary: On Windows, the newer DIA SDKs end up producing function names that contain the return type as well. This means that the function name returned in the test will contain the return type (int) in addition to the name of the function and the type of the input (a(int)). To account for the possibility of both, the test should pass if the function name matches either pattern.

Reviewers: zturner, asmith

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D48654

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py?rev=335906&r1=335905&r2=335906&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py Thu Jun 28 12:42:30 2018
@@ -42,7 +42,7 @@ class BreakpointHitCountTestCase(TestBas
             "There should be a thread stopped due to breakpoint")
 
         frame0 = thread.GetFrameAtIndex(0)
-        self.assertEqual(frame0.GetFunctionName(), "a(int)");
+        self.assertTrue(frame0.GetFunctionName() == "a(int)" or frame0.GetFunctionName() == "int a(int)");
 
         process.Continue()
         self.assertEqual(process.GetState(), lldb.eStateExited)




More information about the lldb-commits mailing list