[Lldb-commits] [PATCH] D48479: Represent invalid UUIDs as UUIDs with length zero

[Leonard Mosescu via Phabricator via lldb-commits]

lemo added subscribers: clayborg, labath, sas.
lemo added a comment.

> However, during parsing you need to know the meaning of a "0000...0" UUID.
>  In a MachO file (at least based on the comments in the code) this value is
>  used to denote the fact that the object file has no UUID. For elf, a
>  "000..0" build-id is a perfectly valid identifier (and the lack of a
>  build-id is denoted by the absence of the build-id section). The extra
>  constructor argument is my way of trying to support both scenarios. The
>  other possibility I see is to have a some kind of a factory function for
>  one of the options (or both). I don't really have a preference between the
>  two.

One solution might be to encapsulate the MachO convention in the MachO
code: check in there (maybe through a helper function) if the UUID is
"000...0" and map it to the empty UUID in that case. The UUID interface
would not have to know/care about this convention. Would this work?


https://reviews.llvm.org/D48479