[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 20 09:09:26 PDT 2018
aprantl added a comment.
This patch is adding new overloads to SBAPI calls that don't return an SBError, such as:
// Old:
void StepOutOfFrame(SBFrame &frame);
// New:
void StepOutOfFrame(SBFrame &frame, SBError &error);
I wonder if it would be easier to use and more consistent with the rest of the API if we instead added an overload that returns an SBError, like this:
// New:
SBError StepOutOfFrameWithError(SBFrame &frame);
// Alternative names that are just as ugly.
SBError StepOutOfFrameE(SBFrame &frame);
SBError StepOutOfFrame2(SBFrame &frame);
@clayborg, @jingham: What do you think?
https://reviews.llvm.org/D47991
More information about the lldb-commits
mailing list