[Lldb-commits] [PATCH] D48351: Move dumping code out of RegisterValue class

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: zturner, jingham, clayborg.
Herald added a subscriber: mgorny.

The dump function was the only part of this class which depended on
high-level functionality. This was due to the DumpDataExtractor
function, which uses info from a running target to control dump format
(although, RegisterValue doesn't really use the high-level part of
DumpDataExtractor).

This patch follows the same approach done for the DataExtractor class,
and extracts the dumping code into a separate function/file. This file
can stay in the higher level code, while the RegisterValue class and
anything that does not depend in dumping can stay go to lower layers.


https://reviews.llvm.org/D48351

Files:
  include/lldb/Core/DumpRegisterValue.h
  include/lldb/Core/RegisterValue.h
  source/Commands/CommandObjectRegister.cpp
  source/Core/CMakeLists.txt
  source/Core/DumpRegisterValue.cpp
  source/Core/EmulateInstruction.cpp
  source/Core/FormatEntity.cpp
  source/Core/RegisterValue.cpp
  source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
  source/Target/ThreadPlanCallFunction.cpp
  source/Target/ThreadPlanTracer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48351.152036.patch
Type: text/x-patch
Size: 14497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180620/7759f97b/attachment.bin>