[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This code looks fine to me.  The docs are a little thin.

You don't say how to make a recognizer anywhere except in the test example.  There should probably be an example in the long help for CommandObjectFrameRecognizerAdd.  Look for instance at the help for "breakpoint command add" which tells you the signature of the Python function you need to add and gives an example.  You should also add a section to www/python-reference.html since that's where people go to see "how can I extend lldb using the Python interface."


https://reviews.llvm.org/D44603