[Lldb-commits] [PATCH] D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 18 04:23:56 PDT 2018


polyakov.alex updated this revision to Diff 151682.
polyakov.alex retitled this revision from "[lldb, lldb-mi] Add method AddCurrentTargetSharedObjectPath to the SBDebugger." to "[WIP] New class SBTargetSettings to store and manipulate all target's properties.".
polyakov.alex edited the summary of this revision.
polyakov.alex added a comment.
Herald added a subscriber: mgorny.

As we discussed previously, it would be nice to have a class in SB API that will manipulate with SBTarget's properties.
I started to work on this and , as I expected, faced with a problem:
`TargetProperties` class doesn't have a property with image search paths while `Target` does. It means that we should have a pointer to `Target` to implement things like 
`SBTargetSettings::AppendImageSearchPath(const char *from, const char *to, SBError &error)`.

We may store an additional pointer to `Target`, but, as I understood, it's not what we want from `SBTargetSettings` to be.
Moreover, it looks strange that image search path isn't a part of `TargetProperties` while executable and debug file search paths are.

I'm looking forward for your comments about this.


https://reviews.llvm.org/D47302

Files:
  include/lldb/API/SBTarget.h
  include/lldb/API/SBTargetSettings.h
  source/API/CMakeLists.txt
  source/API/SBTargetSettings.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47302.151682.patch
Type: text/x-patch
Size: 4059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180618/bbbc0c65/attachment.bin>


More information about the lldb-commits mailing list