[Lldb-commits] [PATCH] D48215: Remove dependency from Host to python

[Zachary Turner via lldb-commits]

The internal api has no guarantees as to its stability.
On Fri, Jun 15, 2018 at 7:48 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg added inline comments.
>
>
> ================
> Comment at: source/API/SBHostOS.cpp:48
> +  case ePathTypePythonDir:
> +    fspec = ScriptInterpreterPython::GetPythonDir();
> +    break;
> ----------------
> Why is this here instead of inside of "HostInfo::GetLLDBPath(path_type,
> fspec);"? Does this mean internal code that calls:
>
> ```
> HostInfo::GetLLDBPath(ePathTypePythonDir, fspec);
> ```
>
> Won't work anymore? Also same for ePathTypeClangDir? Are we trying to
> solve a layering problems by hosing over internal clients?
>
>
> https://reviews.llvm.org/D48215
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180615/60f686d0/attachment.html>