[Lldb-commits] [lldb] r334668 - [FileSpec] Make style argument mandatory for SetFile. NFC

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 13 15:54:52 PDT 2018


Author: jdevlieghere
Date: Wed Jun 13 15:54:52 2018
New Revision: 334668

URL: http://llvm.org/viewvc/llvm-project?rev=334668&view=rev
Log:
[FileSpec] Make style argument mandatory for SetFile. NFC

Update SetFile uses in the unittests.

Modified:
    lldb/trunk/unittests/Host/SymbolsTest.cpp
    lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp

Modified: lldb/trunk/unittests/Host/SymbolsTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Host/SymbolsTest.cpp?rev=334668&r1=334667&r2=334668&view=diff
==============================================================================
--- lldb/trunk/unittests/Host/SymbolsTest.cpp (original)
+++ lldb/trunk/unittests/Host/SymbolsTest.cpp Wed Jun 13 15:54:52 2018
@@ -26,7 +26,8 @@ TEST(SymbolsTest,
   ModuleSpec module_spec;
   // using a GUID here because the symbol file shouldn't actually exist on disk
   module_spec.GetSymbolFileSpec().SetFile(
-      "4A524676-B24B-4F4E-968A-551D465EBAF1.so", false);
+      "4A524676-B24B-4F4E-968A-551D465EBAF1.so", false,
+      FileSpec::Style::native);
   FileSpec symbol_file_spec = Symbols::LocateExecutableSymbolFile(module_spec);
   EXPECT_TRUE(symbol_file_spec.GetFilename().IsEmpty());
 }

Modified: lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp?rev=334668&r1=334667&r2=334668&view=diff
==============================================================================
--- lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp (original)
+++ lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp Wed Jun 13 15:54:52 2018
@@ -72,7 +72,7 @@ TEST_F(ObjectFileELFTest, SectionsResolv
   ASSERT_GT(size, 0u);
 
   ModuleSpec spec{FileSpec(obj, false)};
-  spec.GetSymbolFileSpec().SetFile(obj, false);
+  spec.GetSymbolFileSpec().SetFile(obj, false, FileSpec::Style::native);
   auto module_sp = std::make_shared<Module>(spec);
   SectionList *list = module_sp->GetSectionList();
   ASSERT_NE(nullptr, list);




More information about the lldb-commits mailing list