[Lldb-commits] [PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth added a comment.

My motivation was not to check for different kinds of errors but to ensure that the error code detail doesn't get lost through the SWIG plumbing.  SBErrors seem to be marshaled properly when used as return values, but this is the first one I've seen returned by reference.  The test ensures that the success/fail result makes it, but not that the detail (e.g., the error string) survives the trip.

It's probably not a big deal.


Repository:
  rL LLVM

https://reviews.llvm.org/D48049