[Lldb-commits] [PATCH] D48084: [FileSpec] Delegate common operations to llvm::sys::path

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Utility/FileSpec.cpp:593
+  llvm::SmallString<64> current_path;
+  GetPath(current_path, false);
+  return ConstString(llvm::sys::path::extension(current_path, m_style));
----------------
We won't need the full path in order to get the extension. Should we just get the m_filename as a string here?


================
Comment at: source/Utility/FileSpec.cpp:599
+  llvm::SmallString<64> current_path;
+  GetPath(current_path, false);
+  return ConstString(llvm::sys::path::stem(current_path, m_style));
----------------
We won't need the full path in order to get the extension. Should we just get the m_filename as a string here?


Repository:
  rL LLVM

https://reviews.llvm.org/D48084