[Lldb-commits] [PATCH] D47929: Add modules support for lldb headers in include/

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.


================
Comment at: source/Host/CMakeLists.txt:7
+# Removes all module flags from the current CMAKE_CXX_FLAGS. Used for
+# the Obj-C++ code in lldb which we don't want to build with modules.
+# Reasons for this are that modules with Obj-C++ would require that all
----------------
ObjC++ or Objective C++


================
Comment at: source/Host/CMakeLists.txt:107
     include_directories(SYSTEM ${LIBXML2_INCLUDE_DIR})
-    add_host_subdirectory(macosx
-      macosx/Host.mm
-      macosx/HostInfoMacOSX.mm
-      macosx/HostThreadMacOSX.mm
+    add_subdirectory(macosx/objc)
+    set(LLDBObjCLibs lldbHostMacOSXObjC)
----------------
This is really Objective C++, so `ObjCXX` or `objcxx` would be a more appropriate directory name.


================
Comment at: source/Host/CMakeLists.txt:109
+    set(LLDBObjCLibs lldbHostMacOSXObjC)
+    add_host_subdirectory(maqcosx
       macosx/Symbols.cpp
----------------
macosx

(technically MacOS X is now macOS, but you don't need to change that)


https://reviews.llvm.org/D47929