[Lldb-commits] [PATCH] D48060: Introduce lldb-framework CMake target and centralize its logic

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: cmake/modules/LLDBFramework.cmake:45
+
+  add_dependencies(lldb-framework liblldb lldb-argdumper lldb-server lldb-framework-headers)
+  add_dependencies(finish_swig lldb-framework)
----------------
xiaobai wrote:
> labath wrote:
> > Maybe lldb-argdumper and lldb-server dependencies should be handled as a part of INCLUDE_IN_FRAMEWORK argument to add_lldb_executable? Or do you have other plans for that?
> One of the goals I had in centralizing the framework generation code would be to centralize and make explicit which tools went into the framework. The idea I had was to get rid of the INCLUDE_IN_FRAMEWORK argument to add_lldb_executable. Since add_lldb_executable builds the binary differently when building for the framework (modifying the rpath, changing the output destination and symlinking it to your build tree's bin dir), it should be sufficient just to check for LLDB_BUILD_FRAMEWORK.
> 
> What do you think of this?
Both of the approaches sound reasonable to me. If you want to go this way, then I'm fine with that.


https://reviews.llvm.org/D48060