[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API	using SBError parameter.
    Alexander Polyakov via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Tue Jun 12 11:16:43 PDT 2018
    
    
  
apolyakov added inline comments.
================
Comment at: source/API/SBThread.cpp:1136
   bool result = false;
   if (exe_ctx.HasThreadScope()) {
     Process::StopLocker stop_locker;
----------------
@aprantl do you think that we should use early exit here? There is printing to log at the end of the function, so in case of early exit, we must duplicate `log->Printf()`. Is it worth it?
https://reviews.llvm.org/D47991
    
    
More information about the lldb-commits
mailing list