[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

Kuba (Brecka) Mracek via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 11 22:07:24 PDT 2018


kubamracek added inline comments.


================
Comment at: source/Commands/CommandObjectFrame.cpp:833
+bool CommandObjectFrameRecognizerAdd::DoExecute(Args &command, CommandReturnObject &result) {
+  if (m_options.m_class_name.empty()) {
+    result.AppendErrorWithFormat("%s needs a Python class name.\n", m_cmd_name.c_str());
----------------
Note to self: We should also require -m and -n (otherwise the default is that the recognizer will be called on every single stop point).


https://reviews.llvm.org/D44603





More information about the lldb-commits mailing list