[Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 11 14:02:28 PDT 2018


apolyakov added a comment.

In https://reviews.llvm.org/D47991#1128831, @aprantl wrote:

> Have you looked into making the error the first vs the last argument? If the majority of all SBAPI calls put the error last, we should do this here, too.


As you could see, SBError is on first place only in one function - `StepOver`. When I replaced it to last place, I got an error:

  /home/alexander/workspace/gsoc/llvm/tools/lldb/scripts/./interface/SBThread.i:218: Error: Non-optional argument 'error' follows an optional argument.

so I returned it back.


https://reviews.llvm.org/D47991





More information about the lldb-commits mailing list