[Lldb-commits] [PATCH] D47991: Add method SBThread::StepOver with SBError parameter.

[Leonard Mosescu via Phabricator via lldb-commits]

lemo added inline comments.


================
Comment at: include/lldb/API/SBThread.h:96
 
+  void StepOver(SBError &error,
+                lldb::RunMode stop_other_threads = lldb::eOnlyDuringStepping);
----------------
apolyakov wrote:
> aprantl wrote:
> > Where is the SBAPI documentation that is displayed on http://lldb.llvm.org ? Apparently no in this file, but it must exist *somewhere*, can you update it too, please?
> Due to http://lldb.llvm.org/: `This documentation is generated directly from the source code with doxygen.`. So I think that we don't need to change anything except source files.
While not perfectly consistent across SB API, most methods having an out SBError parameter place it last.


================
Comment at: include/lldb/API/SBThread.h:96
 
+  void StepOver(SBError &error,
+                lldb::RunMode stop_other_threads = lldb::eOnlyDuringStepping);
----------------
lemo wrote:
> apolyakov wrote:
> > aprantl wrote:
> > > Where is the SBAPI documentation that is displayed on http://lldb.llvm.org ? Apparently no in this file, but it must exist *somewhere*, can you update it too, please?
> > Due to http://lldb.llvm.org/: `This documentation is generated directly from the source code with doxygen.`. So I think that we don't need to change anything except source files.
> While not perfectly consistent across SB API, most methods having an out SBError parameter place it last.
I believe you need to update SBThread.i as well. It is required for Python binding through SWIG and it also defines the Python API documentation.


https://reviews.llvm.org/D47991